Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add light source crafting, lighting, extinguishing plus Giant Mole addition #529

Merged
merged 2 commits into from
May 2, 2024

Conversation

Syntax2022
Copy link
Contributor

  • Add the ability to make lanterns and lamps to item-on-item.yml
  • Add LightSources data class to handle when lighting and extinguish light sources
  • Add LightSource.kts to handle the logic when lighting and extinguish light sources
  • Add Firemaking cape and Firemaking cape t as accepted light sources for Giant Mole, including if the players are wearing these capes.

* Add `LightSources` data class to handle when `lighting` and `extinguish` light sources
* Add `LightSource.kts` to handle the logic when `lighting` and `extinguish` light sources
* Add `Firemaking cape` and `Firemaking cape t` as accepted light sources for `Giant Mole`, including if the players are wearing these capes.
@Syntax2022
Copy link
Contributor Author

Syntax2022 commented May 1, 2024

Hey Greg,

With this i ran into some challenges when trying to distinguish different items because there wasn't a "universal" string i could use to ID every item used in this. for example itemOnItem("tinderbox*", "*candle*") { wouldn't work because theres, lanterns, a mining hat and a torch I am assuming not declaring an item when using itemonitem or inventoryItem would be bad practice.

is the current implementation fine due to the usage of the data class?

@GregHib
Copy link
Owner

GregHib commented May 2, 2024

Yeah there's no super easy way, I've added itemOnItems which takes two arrays if you want to pass in a list, otherwise it's just looping over itemOnItem or whatever the call is

@Syntax2022
Copy link
Contributor Author

Yeah there's no super easy way, I've added itemOnItems which takes two arrays if you want to pass in a list, otherwise it's just looping over itemOnItem or whatever the call is

i will do that, thank you

…f acceptable unlit light sources

* Remove a duplicated element in `items.yml`
@Syntax2022 Syntax2022 marked this pull request as ready for review May 2, 2024 10:42
@GregHib GregHib merged commit 4a9b12d into GregHib:main May 2, 2024
2 checks passed
@Syntax2022 Syntax2022 deleted the lightsource branch May 5, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants